Skip to content

docs(stovepipe): Document terminal build IDs - #758

Merged
prathshenoy merged 1 commit into
prath.shenoy/stovepipe-project-result-terminal-buildfrom
prath.shenoy/stovepipe-terminal-build-docs
Sep 30, 2026
Merged

prathshenoy merged 1 commit into
prath.shenoy/stovepipe-project-result-terminal-buildfrom
prath.shenoy/stovepipe-terminal-build-docs

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

What:

  • Document how a terminal build ID is stored on a request and provided to project resolution.

Why:

  • Keep the RFC aligned with the request-side terminal-build behavior.

Test Plan

  • Ask an agent to find inconsistencies between the docs and the code.

Revert Plan

  • Revert this PR. The changes in this PR include documentation only.

Issues

Stack

  1. feat(stovepipe): Store terminal build ID #752
  2. feat(stovepipe): Persist terminal build ID #754
  3. feat(stovepipe): Record terminal build history #756
  4. feat(stovepipe): Pass terminal build to resolver #757
  5. @ docs(stovepipe): Document terminal build IDs #758

@prathshenoy
prathshenoy added this pull request to stack #755 September 29, 2026 01:57
@prathshenoy
prathshenoy marked this pull request as draft September 29, 2026 01:57
@prathshenoy
prathshenoy marked this pull request as ready for review September 29, 2026 13:35
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-docs branch from 3be4f37 to 5ffc0aa Compare September 29, 2026 17:19
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-docs branch from 5ffc0aa to 8f505cf Compare September 29, 2026 17:20
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-docs branch from 8f505cf to 9aa29db Compare September 29, 2026 17:28
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-docs branch from 9aa29db to 9c8303b Compare September 29, 2026 22:22
@prathshenoy prathshenoy changed the title docs(stovepipe): Document terminal builds docs(stovepipe): Document terminal build IDs Sep 29, 2026
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-docs branch from 9c8303b to dcaf36c Compare September 29, 2026 22:28
**What**:
- Document how terminal build identities travel with completed requests.

**Why**:
- Explain how project resolution identifies the build that established an outcome.
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-docs branch from dcaf36c to 4308358 Compare September 29, 2026 22:30
@prathshenoy
prathshenoy added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit 6056310 Sep 30, 2026
16 checks passed
@behinddwalls
behinddwalls deleted the prath.shenoy/stovepipe-terminal-build-docs branch September 30, 2026 00:09
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
## Summary

**What**:
- Store the build ID that establishes a request's terminal state.

**Why**:
- Make the terminal build direct request state for downstream
resolution.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. No downstream consumer needs the terminal build
identity currently.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)


## Stack

1. @ uber#752
1. uber#754
1. uber#756
1. uber#757
1. uber#758
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
## Summary

**What**:
- Persist the terminal build ID together with a request's terminal
state.

**Why**:
- Ensure the first terminal build also becomes the request’s recorded
terminal build.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. It only stops terminal transitions from populating the
nullable field; existing request state remains unchanged.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)

## Stack

1. uber#752
1. @ uber#754
1. uber#756
1. uber#757
1. uber#758
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
## Summary

**What**:
- Record the terminal build ID with a request's terminal history when a
build establishes the state.

**Why**:
- Preserve durable history showing which build established the request’s
final state.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. Terminal history is supplementary and does not change
request state or project resolution.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)

## Stack

1. uber#752
1. uber#754
1. @ uber#756
1. uber#757
1. uber#758
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
## Summary

**What**:
- Provide the terminal build ID when resolving project validation
results.

**Why**:
- Let repository-specific resolution use artifacts from the build that
established the request state.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. It only stops project resolution from receiving the
terminal build ID; request state and history remain unchanged.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)

## Stack

1. uber#752
1. uber#754
1. uber#756
1. @ uber#757
1. uber#758

This branch was previously deployed

1 inactive deployment
stack-rebase — 4308358f Deployed Sep 30, 2026 by prathshenoy via Rebase Stack #543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants